Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@jbergstroem
Copy link

This fixes build issues with node 12.x and NaN, most namely IsNearDeath.

Newer versions of node (v8) removed it after its deprecation period.
Upstream discussion/removal here: nodejs/nan#842

An example build traceback would look something like:

In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object,
      v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(persistent().IsNearDeath());
           ~~~~~~~~~~~~ ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/assert.h:93:25: note: 
      expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)

This fixes build issues with node 12.x and NaN,
most namely `IsNearDeath`.
@nschonni
Copy link
Contributor

Thanks, but the nan version is still in the ^ range already. We can't bump node-gyp because it breaks old Node (bunch of closed PRs for this already)

@nschonni nschonni closed this Jun 10, 2019
@jbergstroem
Copy link
Author

So, 0.x builds seems to fail; not sure why those are even in the matrix since even gyp 3.x (currently leaned on) is node 4 or newer.

@jbergstroem
Copy link
Author

We can't bump node-gyp because it breaks old Node (bunch of closed PRs for this already)

Posted while I was writing. Thanks for that. I'll look at what dependency chain that breaks for me then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants