chore: consistent CI behaviour #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deterministic resolving order
For the RefinedPower and RefinedRDLib with incompatible versions test, the error depends on the order in which the mods are added to the lockfile. However, ResolveModDependencies does not have a consistent order of the results, so the order in which mods are added was random, meaning reruning the test would sometimes pass and sometimes fail.
Pin golangci-lint version
Each minor version bump of golangci-lint can break a project's linting, as new rules might be added which the project does not yet follow. Pinning the version ensures that commits and pull requests do not fail linting on code they have not changed simply because a newer version of golangci-lint is used.
Pinned to v1.51 as v1.52 adds the revive unused-parameter rule, which the current code fails. Updating the code to pass that would result in merge conflicts with the other PRs, so it can be done later