Skip to content

fix: webpack 5 build #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diemol merged 2 commits into from
Jun 5, 2023
Merged

fix: webpack 5 build #35

diemol merged 2 commits into from
Jun 5, 2023

Conversation

@djejaquino
Copy link
Contributor

@djejaquino djejaquino commented Jun 2, 2023

  • Fixes Webpack 5 build by not directly importing Node's built in url module. See Webpack error #34
  • Adds Yarn command to README
  • Patches dependencies vulnerabilities

@djejaquino djejaquino mentioned this pull request Jun 2, 2023
Closed
diemol
diemol approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @djejaquino!

@diemol diemol merged commit a6d9512 into saucelabs:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djejaquino @diemol