-
Notifications
You must be signed in to change notification settings - Fork 1
Description
First I want to say thank you for providing this utility. It seem to be very concisely written, and provides the binout data in a very easy to understand, and use, format. It has proved most useful to my current project.
I ran into a couple if issues when reading large datasets that exceeded the initSize. The first occurred when reading a large nodout data set, and occurred after stateLimMax was increased by initSize on line 97. The problem was that when binin was being initialized with zeros (line 119), state:stateLimMax was not equal to iniSize, so the array on the left was one element larger that the array on the right. My solution was to subtract one when increasing stateLimMax.
The second issue occurred when I was reading a large elout data set. The problem was similar to the firs, in that when initializing binin on line 119, the array on the left was not the same size as the array on the right. But this time the cause was that "state" was 1 instead of "stateLimMax - initSize". My solution was to add the "else" phrase to the if statement that begins on line 96.
I've provided my updates in the enclosed "get_binout_data_r2.txt" file. These updates may not be the best way to address the issues noted above, but they do seem to give the correct results for my purposes. Let me know if there are any question, and thanks again for providing this utility.