-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…/webpack/dev/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-14724253
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to resolve a security vulnerability by upgrading webpack from version ^1.14.0 to ^2.2.0. While this is a necessary security fix, the upgrade to a new major version of webpack introduces breaking changes that are not addressed in this PR. The current webpack configuration (fixtures/packaging/webpack/dev/config.js) will fail with webpack v2, breaking the build for this fixture. Furthermore, another fixture (fixtures/packaging/webpack/prod/package.json) also contains the vulnerable webpack dependency and has not been updated. To ensure the project remains functional and fully secure, both the webpack configuration and the missed dependency update need to be addressed.
| "name": "webpack-dev-fixture", | ||
| "dependencies": { | ||
| "webpack": "^1.14.0" | ||
| "webpack": "^2.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading webpack to version 2.x is a breaking change. The associated configuration file, fixtures/packaging/webpack/dev/config.js, uses the resolve.root property, which is no longer supported in webpack v2 and will cause the build to fail. This property should be migrated to resolve.modules.
Example update for fixtures/packaging/webpack/dev/config.js:
resolve: {
modules: [
path.resolve('../../../../build/node_modules/')
]
}Additionally, the prod fixture at fixtures/packaging/webpack/prod/package.json also uses the vulnerable version of webpack and should be updated as well to fully mitigate the security risk.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
fixtures/packaging/webpack/dev/package.jsonfixtures/packaging/webpack/dev/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-14724253
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling