Merged
Conversation
npgarcia
commented
Mar 15, 2016
npgarcia
commented
- Moving After and Before hooks to a class named Hooks
- Starting steps to contain only steps
- Added try-catch to screenshot in after hook
| import java.io.IOException; | ||
|
|
||
|
|
||
| public class Hooks { |
Member
There was a problem hiding this comment.
Where is this class being used?
Author
There was a problem hiding this comment.
This class will be used to contain the Before and After Hooks.
So will be used every time a scenario run.
Member
There was a problem hiding this comment.
Ok thanks. Probably it's a good idea to add documentation on how and why to use this methods.
Contributor
There was a problem hiding this comment.
That information is already in Cucumber page, I don't see the need of duplicating the information in here.
Member
There was a problem hiding this comment.
NVM, I was not clear of how this was working :) But @ulisespulido was kind enough to explain to me.
added 2 commits
March 16, 2016 08:54
| try { | ||
| final byte[] screenshot = ((TakesScreenshot) driver).getScreenshotAs(OutputType.BYTES); | ||
| scenario.embed(screenshot, "image/png"); | ||
| } catch (WebDriverException e){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.