Merged
Conversation
|
@sethlyons AFAIK, when i wrote my version, i just take this part from Windows or Linux template: https://github.com/saz/puppet-memcached/blob/master/templates/memcached_windows.erb#L29 in those times in memcached was not able to specify logfile (it seems now nothing has changed). But now i see in Linux tamplate used pipe end redirect to logger ;-) https://github.com/saz/puppet-memcached/blob/master/templates/memcached_sysconfig.erb#L28 May be it better solution for FreeBSD too. |
Owner
|
I'll merge this PR now. Thanks to all of you! |
|
Great! Finally I can remove my fork for FreeBSD-users now ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a continuation of #79 and incorporates some of the changes from #73.
@olevole was there really not a better way to incorporate
$logfilethan to redirect to it? that seems really ugly.