Skip to content

allow custom runtime params on freebsd#81

Merged
saz merged 1 commit intosaz:masterfrom
jewjitsu:add_freebsd
Nov 15, 2016
Merged

allow custom runtime params on freebsd#81
saz merged 1 commit intosaz:masterfrom
jewjitsu:add_freebsd

Conversation

@sethlyons
Copy link
Copy Markdown
Contributor

this is a continuation of #79 and incorporates some of the changes from #73.

@olevole was there really not a better way to incorporate $logfile than to redirect to it? that seems really ugly.

@olevole
Copy link
Copy Markdown

olevole commented Nov 14, 2016

@sethlyons AFAIK, when i wrote my version, i just take this part from Windows or Linux template:

https://github.com/saz/puppet-memcached/blob/master/templates/memcached_windows.erb#L29

in those times in memcached was not able to specify logfile (it seems now nothing has changed). But now i see in Linux tamplate used pipe end redirect to logger ;-)

https://github.com/saz/puppet-memcached/blob/master/templates/memcached_sysconfig.erb#L28

May be it better solution for FreeBSD too.

@saz
Copy link
Copy Markdown
Owner

saz commented Nov 15, 2016

I'll merge this PR now.
If any of you know a better way of the log handling part, please send in a new PR.

Thanks to all of you!

@saz saz merged commit 41b1ec1 into saz:master Nov 15, 2016
@olevole
Copy link
Copy Markdown

olevole commented Nov 15, 2016

Great! Finally I can remove my fork for FreeBSD-users now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants