Removed nested level of message in HttpTextNormalizer#194
Merged
dangerink merged 5 commits intosberdevices:mainfrom Feb 21, 2022
Merged
Removed nested level of message in HttpTextNormalizer#194dangerink merged 5 commits intosberdevices:mainfrom
dangerink merged 5 commits intosberdevices:mainfrom
Conversation
intsynko
approved these changes
Feb 4, 2022
sharifullinildus
approved these changes
Feb 8, 2022
christinadomanskaya
approved these changes
Feb 8, 2022
intsynko
suggested changes
Feb 8, 2022
dangerink
reviewed
Feb 9, 2022
| answer = batch[0] | ||
|
|
||
| if "message" not in answer: | ||
| raise NormalizationError(f"Malformed Message Received: {batch}") |
Collaborator
There was a problem hiding this comment.
орбработка таких ошибок куда то перенесена или совсем убрана? если совсем, то почему?
Collaborator
There was a problem hiding this comment.
в данном случае обработка вообще убрана и на уровне result = [item["message"] for item in response.json()] будет рейситься KeyError: key 'message' not found. Есть ли разница что будет рейситься в этом месте?
Collaborator
There was a problem hiding this comment.
Если это действительно важно, то может обернуть так @justanotheruser:
try:
result = [item["message"] for item in response.json()]
except KeyErrror:
raise NormalizationError(f"Malformed Message Received: {batch}")
intsynko
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was created after changing _normalize_batch https://github.com/sberdevices/smart_app_framework/pull/189/files