Fix #129: Implement Arrays Validation Rule 20116 for SBaseRef missing indices#290
Open
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Open
Fix #129: Implement Arrays Validation Rule 20116 for SBaseRef missing indices#290dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Conversation
… missing indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves Issue #129, where the Arrays validation was failing to check rule
20116. Previously, if anSBaseRefpointed to an array (an object with aListOfDimensions) but lacked the requiredIndexobjects, the validator would silently pass instead of throwing the expected error.Changes
SBaseRefIndicesCheck.javain the arrays constraints package. This class safely looks up the referenced element (usinggetIdRef()orgetElementByMetaId()) and checks if the target has dimensions. If it does, it verifies that the referencingSBaseRefcontains aListOfIndices.ARRAYS_20116to theGENERAL_CONSISTENCYchecklist inArraysSBasePluginConstraints.javaso the JSBML validation engine actively runs the new check.Validation
arraysextension (mvn clean test-compile -pl extensions/arrays).mvn test -pl extensions/arrays).Closes #129