Fixes RNDFPBannerView to allow tap on a DFP Banner #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RNDFPBannerView frame to allow the user to tap on a DFP Banner. This is related to sbugert#70.
|
@aparedes works, thanks! |
sbugert#66) * Replace the deprecated event dispatching via RCTEventDispatcher with RCTBubblingEventBlocks for iOS. * Fix broken build. * Fix broken include due to bad merge. * Use RCTBubblingEventBlocks in RNAdMobInterstitial & RNAdMobRewarded as well. * Revert "Use RCTBubblingEventBlocks in RNAdMobInterstitial & RNAdMobRewarded as well." This reverts commit 3bec144. * Update RNDFPBannerView.h Added right include check
Collaborator
|
The banners have been totally refactored in v2 of the library, where tapping on the banners is no problem. You can track its development here: #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RNDFPBannerView frame to allow the user to tap on a DFP Banner.
This is related to #70 and #88
Credits to @ndbroadbent