Skip to content

Update Enumerations.scala #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juanpedromoreno merged 1 commit into from
May 18, 2020
Merged

Update Enumerations.scala #190

juanpedromoreno merged 1 commit into from
May 18, 2020

Conversation

@joelittlejohn
Copy link
Contributor

@joelittlejohn joelittlejohn commented May 17, 2020 •
edited
Loading

Explain that enum ids are indexed from 0. Also, we need to extend Val when adding methods to enums, not Value.

juanpedromoreno
juanpedromoreno approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpedromoreno juanpedromoreno merged commit 4ee5df4 into scala-exercises:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelittlejohn @juanpedromoreno