Correct a minor regression in Literal Numbers: remove duplicate exercise 'g' from LiteralNumbers (Floats section) #261
+4
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've noticed that PR #169 seems to have introduced a minor error in Literal Numbers: previously, the values in the Float section looked like this:
This version used both
93e-9and93E-9, to demonstrate that both are acceptable ways of representing the exponent. Furthermore,iused9.23E-9D, to show that uppercase double literals work. But after #169, it looks like this:In this version, both
fandgare the same:93e-9, andihas been swapped to lowercase. Unless I'm mistaken, this was probably not what's intended here! However, I see what caused this- looks like @juanpedromoreno was tidying up the codebase with somescalafmtmagic after upgrading the version, andscalafmtstopped liking the uppercase "E" and "D". So, I would propose to fix this by settingliterals.scientificandliterals.doubletoUnchanged, allowing you to revert the Literal Numbers exercise to the prior format.Alternatively, if you prefer to keep your
.scalafmt.confas-is, you could just remove the duplicate entrygin the Literal Numbers exercise and call it a day. If you prefer this, let me know, and I will revise my PR accordingly.