Turn Promise trait into a class with executor constructor parameter. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Use Any or _ as the result type of functions instead of Unit. It helps with inference in some cases. The caller of the function does not demand that a Unit be returned; it doesn't care what value is returned because it ignores it. So Any is more appropriate.
Member
|
That's all. Please amend and force-push your commit to the PR branch, then comment on the PR to notify me. |
Contributor
Author
|
@sjrd Done! Thanks for feedback! |
Member
|
LGTM |
sjrd
added a commit
that referenced
this pull request
Aug 22, 2015
Turn Promise trait into a class with executor constructor parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I write a js library, that converts scala Futures into javascript Promises. To instantiate a Promise within scala.js code it needs to be a class