Add URL.searchParams (URLSearchParams) #361
Conversation
| * MDN | ||
| */ | ||
| @js.native | ||
| trait URLSearchParamsInterface extends js.Object { |
There was a problem hiding this comment.
There doesn't seem to exist an URLSearchParamsInterface even in the IDL definitions. Consider just defining the class URLSearchParams.
There was a problem hiding this comment.
Fixed in 1db81ff
It was separated as MDN says URLSearchParams has separate "interface" and constructor.
But, same name between trait and class is not allowed in Scala, so it was suffixed with ~Interface.
By separating trait, we can have our own class that implements URLSearchParams interface.
However, I change my mind to just define class, since URL is defined so.
| } | ||
|
|
||
| /** | ||
| * The URLSearchParams() constructor creates and returns a new URLSearchParams object. Leading '?' characters are ignored. |
There was a problem hiding this comment.
Please wrap lines at 80 characters.
There was a problem hiding this comment.
Removed this line during merging trait and class.
| */ | ||
| @js.native | ||
| @JSGlobal | ||
| class URLSearchParams extends URLSearchParamsInterface { |
There was a problem hiding this comment.
The class should extend js.Iterable[js.Tuple2[String, String]].
| def entries(): js.Iterator[js.Tuple2[String, String]] = js.native | ||
|
|
||
| @JSName(js.Symbol.iterator) | ||
| def values(): js.Iterator[String] = js.native |
There was a problem hiding this comment.
Those two methods with different signatures and the same @JSName make no sense. I think what you wanted is a single def iterator(): js.Iterator[js.Tuple2[String, String]] to conform to the interface of js.Iterable[js.Tuple2[String, String]]. The methods entries() and values() should not have any @JSName. It also seems that you're missing the def keys() method.
There was a problem hiding this comment.
Correct.
Implemented js.Iterable[js.Tuple2[String, String]] and used @JSName to override def jsIterator.
keys also added.
sjrd
left a comment
sjrd
left a comment
There was a problem hiding this comment.
An unrelated change made it into the PR, which should not be there. Otherwise good to go.
| // fall back to copying the data | ||
| val tempBuffer = ByteBuffer.allocateDirect(data.remaining) | ||
| val origPosition = data.position | ||
| val origPosition = data.position() |
There was a problem hiding this comment.
This change is unrelated and should not be in this commit/PR.
There was a problem hiding this comment.
Ah, indeed.
Since it was fixed in another PR, I will rebase and exclude unrelated change.
2 participants
Closes #339
URLSearchParams is widely-adopted standard.