Add support for Web NFC API #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
FabioPinheiro
commented
Aug 12, 2023
FabioPinheiro
commented
Aug 12, 2023
This comment was marked as resolved.
This comment was marked as resolved.
FabioPinheiro
commented
Aug 12, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
c3d4f22 to
0072cb8
Compare
FabioPinheiro
changed the title
FabioPinheiro
added a commit
to FabioPinheiro/scala-did
that referenced
this pull request
Aug 16, 2023
zetashift
reviewed
Aug 19, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
599b9c5 to
a34b0bd
Compare
armanbilge
reviewed
Aug 21, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
2 times, most recently
from
0742064 to
d6dce7c
Compare
FabioPinheiro
added a commit
to FabioPinheiro/scala-did
that referenced
this pull request
Aug 22, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
d6dce7c to
e034e26
Compare
zetashift
reviewed
Aug 22, 2023
zetashift
reviewed
Aug 22, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
3524a12 to
effb33f
Compare
FabioPinheiro
added a commit
to FabioPinheiro/scala-did
that referenced
this pull request
Aug 24, 2023
armanbilge
reviewed
Sep 17, 2023
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
69ac9a1 to
1cc5447
Compare
Contributor
Author
|
@armanbilge Thanks for the review |
armanbilge
reviewed
Sep 29, 2023
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
I'm sorry, the example I linked was wrong 😕 all these defs should be vars.
Apply suggestions from code review Co-authored-by: zetashift <rskaraya@gmail.com> Co-authored-by: Arman Bilge <armanbilge@gmail.com>
FabioPinheiro
force-pushed
the
Web_NFC_API
branch
from
23c2c77 to
bd14f33
Compare
armanbilge
reviewed
Sep 29, 2023
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
Hmm, did you change those defs to vars? Some of them should be defs. If it is "read-only", then it is a def.
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
Contributor
Author
|
https://w3c.github.io/web-nfc/ format seems more clear to follow. |
FabioPinheiro
added a commit
to FabioPinheiro/scala-did
that referenced
this pull request
Sep 29, 2023
FabioPinheiro
added a commit
to FabioPinheiro/scala-did
that referenced
this pull request
Sep 29, 2023
zetashift
approved these changes
Oct 14, 2023
Contributor
zetashift
left a comment
zetashift
left a comment
There was a problem hiding this comment.
LGTM! Thank you for this awesome PR!
Contributor
Author
|
Would be nice to have this merged before the next release |
Contributor
|
@FabioPinheiro sorry for the wait, and thank you so much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web NFC API - https://developer.mozilla.org/en-US/docs/Web/API/Web_NFC_API