Skip to content

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 20, 2019

@SethTisue SethTisue changed the title advance Scala SHA and fix akka-stream 2.13: advance Scala SHA and fix akka-stream Dec 20, 2019
@SethTisue
Copy link
Member Author

@SethTisue SethTisue self-assigned this Dec 20, 2019
@SethTisue
Copy link
Member Author

SethTisue commented Dec 20, 2019

https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2919/artifact/logs/scala-xml-build.log

[scala-xml] [error] Test scala.xml.CompilerErrors.t7185 failed: assertion failed: overloaded method apply with alternatives:
[scala-xml] [error]   (f: scala.xml.Node => Boolean)scala.xml.NodeSeq <and>
[scala-xml] [error]   (i: Int)scala.xml.Node
[scala-xml] [error]  cannot be applied to (), took 0.156 sec
[scala-xml] [error] Failed: Total 200, Failed 1, Errors 0, Passed 199
[scala-xml] [error] Failed tests:
[scala-xml] [error] 	scala.xml.CompilerErrors
[scala-xml] [error] (xml / Test / test) sbt.TestsFailedException: Tests unsuccessful

@ashawley can you make sense of this?

@SethTisue
Copy link
Member Author

SethTisue commented Dec 20, 2019

The scala-xml problem is reproducible outside dbuild with ++2.13.2-bin-079713c followed by xml/test

my secret intellectual & magical powers (shhhhh, don't tell, but I don't actually have those — I have something better, I have git bisect) located the culprit Scala PR: scala/scala#8592

so, just a very sensitive test, it seems.

to keep this PR focused, I'll just use a slightly older Scala SHA and worry about scala-xml later, unless @ashawley worries about it first ;-)

queued: https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2928/

@som-snytt
Copy link

@SethTisue I did mention on that PR that it may change someone's life, I didn't say for the better.

@SethTisue
Copy link
Member Author

like sands through the hourglass, so are the

2016-0824-DAYS-AboutImage-1920x1080-KO

@SethTisue SethTisue merged commit afc326c into scala:2.13.x Dec 21, 2019
@SethTisue SethTisue deleted the akka-fix branch December 21, 2019 15:02
@SethTisue
Copy link
Member Author

SethTisue commented Dec 21, 2019

@dwijnand I merged this even though Lagom is failing (for the same reason akka-stream was failing); see lagom/lagom#2579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants