Grammar and Cleanup in Scala 3 Macro Documentation #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This has merge conflicts now. It's been open for 3 weeks with no activity. If this repo isn't interested in merging small grammar-correcting PRs in a timely manner (contrary to the readme), I'm of a mind to just close it. |
nicolasstucki
suggested changes
Aug 3, 2021
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
Looks great. Just needs some minor tweaks and a rebase.
Contributor
Author
|
Thanks for the extra recommended tweaks! Everything has been updated now. |
nicolasstucki
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to familiarize myself with Scala 3 macros today and found multiple issues in the documentation that I felt I could quickly clean up. There are other bigger issues and missing sections, but I tried to limit myself to just cleaning up the grammar of what was already there.
I made a few code snippet changes as well. For these, I usually tried to make things more consistent without trying to reinvent the code in question.