Skip to content

add transparent modifier to defaultValue #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julienrf merged 1 commit into from
Jul 25, 2021
Merged

add transparent modifier to defaultValue #2138

julienrf merged 1 commit into from
Jul 25, 2021

Conversation

@tkawachi
Copy link
Contributor

@tkawachi tkawachi commented Jul 24, 2021 •
edited
Loading

val dInt: Some[Int] = defaultValue[Int] etc. fail to compile without transparent.

@tkawachi
add transparent modifier to defaultValue
445d23f 
It failes to compile  without transparent.
@bishabosha bishabosha requested a review from julienrf July 24, 2021 11:19
julienrf
julienrf approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@julienrf julienrf merged commit 02f982e into scala:main Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrf julienrf julienrf approved these changes

Assignees

@julienrf julienrf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tkawachi @julienrf