add documentation for scala3-migrate in the migration guide #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlachkar
force-pushed
the
scala3-migrate
branch
2 times, most recently
from
c55023e to
1a025a4
Compare
Contributor
Author
|
please can you do a quick review @adpi2 ? thanks! I can not add you as a reviewer! |
adpi2
approved these changes
Jan 7, 2022
Member
adpi2
left a comment
adpi2
left a comment
There was a problem hiding this comment.
Some typos and suggestions, otherwise it looks good to me.
mlachkar
force-pushed
the
scala3-migrate
branch
2 times, most recently
from
dd8acf4 to
9dfbb3e
Compare
mlachkar
force-pushed
the
scala3-migrate
branch
from
9dfbb3e to
98f0f0f
Compare
julienrf
reviewed
Jan 18, 2022
Contributor
|
I see several discussions that have not been resolved, could you please mark them as resolved (if they are), or explain why you think they should not be addressed? |
Contributor
Author
|
Thank you for your review. All comments have been addressed, and are marked as |
Contributor
Author
|
the build is failing because of:
Not related to my PR. maybe it's a temporary issue en typelevel, otherwise I will fix it in another PR |
julienrf
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.