Skip to content

Conversation

@rockpunk
Copy link
Contributor

(part of sf scala spree 2022)

This PR addresses japanese translation for #2449

@xuwei-k xuwei-k requested a review from eed3si9n June 10, 2023 23:10
@rockpunk
Copy link
Contributor Author

rockpunk commented Jun 11, 2023

I should say, my Japanese is likely subpar in places, so I would appreciate any suggestions from @eed3si9n to make things read more natural. よろしく!

@eed3si9n
Copy link
Member

@rockpunk Thanks for the contribution!

I should say, my Japanese is likely subpar in places, so I would appreciate any suggestions from @eed3si9n to make things read more natural. よろしく!

I haven't had time to track all the details in contents so I haven't ok'ed it, but your Japanese seems totally fine.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions.

rockpunk and others added 4 commits June 11, 2023 21:39
Co-authored-by: eugene yokota <eed3si9n@gmail.com>
Co-authored-by: eugene yokota <eed3si9n@gmail.com>
Co-authored-by: eugene yokota <eed3si9n@gmail.com>
Co-authored-by: eugene yokota <eed3si9n@gmail.com>
@rockpunk rockpunk requested a review from eed3si9n June 12, 2023 04:40
@rockpunk
Copy link
Contributor Author

Thank you for all the suggestions!

@eed3si9n eed3si9n merged commit 78b8cb9 into scala:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants