Skip to content

Conversation

@Philippus
Copy link
Member

@Philippus Philippus commented Apr 23, 2019

Support was dropped for scala 2.11, but this was not reflected in the unmanaged source directory names yet. The naming in the PR is the naming suggested in https://github.com/scala/collection-strawman/wiki/FAQ#how-do-i-cross-build-my-project-against-scala-212-and-scala-213.

@Philippus Philippus requested a review from ashawley April 23, 2019 08:38
@ashawley
Copy link
Member

ashawley commented Apr 23, 2019

When the first 2.14 milestone drops, we'll rename the directories again? Maybe they should be just be named scala-2.12 and scala-2.13?

@Philippus
Copy link
Member Author

Philippus commented Apr 23, 2019

We could do that, but maybe we won't need scala 2.14 specific changes?

@ashawley
Copy link
Member

Scala 3 would suggest there will be more compatibility changes in 2.14, but we can just revisit this when 2.14 starts rolling out.

@ashawley ashawley merged commit 9e37824 into scala:master Apr 23, 2019
@Philippus Philippus deleted the rename-unmanaged-source-directories branch April 23, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants