Skip to content

Override scalajs-library versionCheck #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashawley wants to merge 1 commit into from
Closed

Override scalajs-library versionCheck #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ThisBuild / startYear := Some(2002)
ThisBuild / licenses += (("Apache-2.0", url("https://www.apache.org/licenses/LICENSE-2.0")))

// because it doesn't declare it itself
ThisBuild / libraryDependencySchemes += "org.scala-js" %% "scalajs-library" % "semver-spec"
ThisBuild / libraryDependencySchemes += "org.scala-js" %% "scalajs-library" % "always"
Copy link
Contributor

@julienrf julienrf Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the recommended way of fixing the issue.

We should remove this line now that Scala.js does declare its versioning scheme.

And we should relax the compatibility intention to Compatibility.BinaryCompatible.

Copy link
Member Author

@ashawley ashawley Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good to know. I didn't realize we could change that policy, and also that it would fix the dependency issue.


lazy val configSettings: Seq[Setting[_]] = Seq(
unmanagedSourceDirectories ++= {
Expand Down