Regression: Unable to emit reference to constructor ... class is not accessible

[makarius]

Compiler version

OK: scala-3.3.4
BAD: scala-3.3.5
BAD: scala-3.3.7
BAD: scala-3.7.4

Minimized code

class Test extends javax.swing.JFrame { class Acc extends AccessibleJFrame }

Output

-- Error: ---------------------------------------------------------------------------------------------------------------------
1 |class Test extends javax.swing.JFrame { class Acc extends AccessibleJFrame }
  |                                                          ^^^^^^^^^^^^^^^^
  |Unable to emit reference to constructor AccessibleJFrame in class AccessibleJFrame, class AccessibleJFrame is not accessible in class Acc
1 error found

Expectation

I am using the Java Accessibility API (JAAPI) in Scala, which occasionally requires to instantiate protected inner classes. The above example used to work with scala-3.3.4, but later the compiler complained about it. It does work in Java 21.

[Gedochao]

Last good LTS release: 3.3.4
First bad LTS release: 3.3.5
Last good release: 3.6.0-RC1-bin-20240911-4891858-NIGHTLY
First bad release: 3.6.0-RC1-bin-20240912-8e9ded0-NIGHTLY
e66860b is the first bad commit (#21364)
cc @KacperFKorban

[KacperFKorban]

@Gedochao The commit seems unrelated. I'm pretty sure that no inlining should be done when interacting with Java code. I reverted the commit locally and the snippet still fails.
Is there a chance that this was the bisect script following a wrong path? (AFAIK main quite a few commits that don't build)

[Gedochao]

Is there a chance that this was the bisect script following a wrong path? (AFAIK main quite a few commits that don't build)

Yep, it might be a bisect failure... that is the cost of us not enforcing squashing commits on every merge, I guess.
In that case, the culprit could be anything between e66860b and 4891858 😐

[tanishiking]

This regression starts from e7d479f (Previsouly it worked because if qual1.tpe.derivesFrom(sym.owner) is true, we anyway use select(qual1, sym), which isn't good and causes an error fixed by #21362),
but the root cause of this issue is that isJvmAccessible(class AccessibleJFrame) is false at

scala3/compiler/src/dotty/tools/dotc/transform/Erasure.scala

Lines 779 to 780 in b2850be

	case qual1 if !isJvmAccessible(qual1.tpe.typeSymbol)
	|| !qual1.tpe.derivesFrom(sym.owner) =>

If I understand correctly, it should be true, because Acc exnteds AccessibleJFrame is in the same package as the current owner (JFrame).