Skip to content

Conversation

@odersky
Copy link
Contributor

@odersky odersky commented Nov 13, 2020

Drop some methods in DottyPredef that are also in Predef

Drop some methods in DottyPredef that are also in Predef
  - bring back valueOf, the old one fails many tests
  - correct check file
  - exclude pickling test involving Predef.implicitly
@odersky odersky force-pushed the reduce-dottypredef branch 2 times, most recently from 5e8c8f7 to 9c4f6f2 Compare November 17, 2020 12:31
}

@Test def inlineLocally = {
/** Disabled since locally comes from Predef now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider actually removing the code instead of commenting it out.

@sjrd
Copy link
Member

sjrd commented Nov 19, 2020

@odersky Not sure whether you had seen my comment, since I posted here about 30 seconds before you assigned me as a reviewer.

@odersky odersky merged commit dda6be5 into scala:master Nov 20, 2020
@odersky odersky deleted the reduce-dottypredef branch November 20, 2020 13:04
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants