Add a "terminal" callback to TastyInspector #10310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface allows performing arbitrary operations on all compilation units.
romanowski
reviewed
Nov 13, 2020
| override def run(implicit ctx: Context): Unit = | ||
| if !alreadyRan then | ||
| val qctx = QuoteContextImpl() | ||
| self.finishProcessingCompilationUnits(using qctx) |
Contributor
There was a problem hiding this comment.
What if finishProcessingCompilationUnits throws exception? Shound't we use
try self.finishProcessingCompilationUnits(using qctx) finally alreadyRan = true here?
Contributor
Author
There was a problem hiding this comment.
I think that this is already handled in the code that orchestrates Phase runs, Tasty Inspector will continue even if processCompilationUnit throws an exception and there's no special code for doing that above.
Contributor
There was a problem hiding this comment.
My point was not to run finishProcessingCompilationUnits twice in such case (there was only finally there without catch)
nicolasstucki
suggested changes
Nov 17, 2020
abgruszecki
force-pushed
the
tasty-final-callback
branch
from
79ec13b to
065c81b
Compare
abgruszecki
force-pushed
the
tasty-final-callback
branch
from
065c81b to
b8c33c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicolasstucki I think we should allow defining a "final" callback in TastyInspector that runs after all compilation units are processed. The reason is very simple - this way, users can encode arbitrary operations on the full list of compilation units.
I've found a bunch of uses for that in the doctool and I suspect that external users will quickly need this as well.