Scala3doc/doc context #10568
Merged
Scala3doc/doc context #10568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
force-pushed
the
scala3doc/doc-context
branch
from
9784cdb to
1447c91
Compare
abgruszecki
reviewed
Dec 1, 2020
Contributor
abgruszecki
left a comment
abgruszecki
left a comment
There was a problem hiding this comment.
Other than the filename nitpick, LGTM.
|
|
||
| import scala.collection.JavaConverters._ | ||
|
|
||
| class NavigationCreator(using ctx: DocContext) extends PageTransformer: |
Contributor
There was a problem hiding this comment.
Typo in filename, should be NavigationCreator.scala
romanowski
force-pushed
the
scala3doc/doc-context
branch
from
008c9be to
b135490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.