Fix #9740: harden type checking for pattern match on objects #11327
Conversation
liufengyun
force-pushed
the
fix-9740b
branch
2 times, most recently
from
2c72a6c to
ea11087
Compare
|
test performance please |
|
performance test scheduled: 13 job(s) in queue, 1 running. |
|
|
||
| // Case 3: Same as above; should match the second case and print the length of the string | ||
| any match { | ||
| case C(IsInt, i) if i < 10 => println(s"An Int less than 10") |
There was a problem hiding this comment.
There's no checkfile for neg tests?? Sounds very unstable to not verify the failure reasons...
I wanted to see on what grounds this now fails to compile.
There was a problem hiding this comment.
We tend to avoid check files as they incur maintenance overhead. In contrast, we check the line numbers of reported errors agree with the comments // error in the source code.
dwijnand
left a comment
dwijnand
left a comment
There was a problem hiding this comment.
LGTM, with 1 jaw-dropping realisation...
We enforce that when pattern match on an object, the object should be a subtype of the scrutinee type. Reasons for doing so: - such code patterns usually implies hidden errors in the code - it's always safe/sound to reject the code We could check whether `equals` is overridden in the object, but - it complicates the protocol - overriding `equals` of object is also a bad practice - there is no sign that the slightly improved completeness is useful
liufengyun
force-pushed
the
fix-9740b
branch
from
ea11087 to
b04150c
Compare
| mapOver(tp) | ||
| } | ||
|
|
||
| if tree.symbol.is(Module) |
There was a problem hiding this comment.
Would it make sense to check this also for other values that are not modules?
There was a problem hiding this comment.
We cannot check non-module values due to aliasing.
This is a follow-up of scala#11327.
This is a follow-up of scala#11327. We cannot generalize further without complications: ``` val b = 'b' 56 match case 'a' => case `b` => ```
This is a follow-up of scala#11327. We cannot generalize further without complications: ``` val b = 'b' 56 match case 'a' => case `b` => ```
5 participants
Fix #9740: harden type checking for pattern match on objects
We enforce that when pattern match on an object, the object should be
a subtype of the scrutinee type. It aligns with Scala 2 behavior.
Reasons for doing so:
We could check whether
equalsis overridden in the object, butequalsof object is also a bad practice