Fix Mirror.Product for type lambdas #14003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry but I will mark this ready for review because it requires a maintainer to approve the CI run |
We don't need to guess how the type parameters should be substituted. Instead we can use the result type directly to obtain the member type. This exposed another issue - the mirrored type contained type variables. To get rid of them we apply `Type.stripTypeVar` recursively.
joroKr21
force-pushed
the
product-mirror
branch
from
1128dbc to
1139338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to guess how the type parameters should be substituted.
Instead we can use the result type directly to obtain the member type.
This exposed another issue - the mirrored type contained type variables.
To get rid of them we apply
Type.stripTypeVarrecursively.Fixes #13859