Remove deprecation of compiletime.ops.int.ToString
#14217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Jan 5, 2022
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
There's a stray merge commit in this PR, can you remove it?
| * @syntax markdown | ||
| */ | ||
| @deprecated("Use compiletime.ops.any.ToString instead.","3.2.0") | ||
| // @deprecated("Use compiletime.ops.any.ToString instead.","3.2.0") //uncomment when reaching 3.2.0 |
Member
There was a problem hiding this comment.
The comment should be indented as much as the next line.
Contributor
|
It's too bad |
soronpo
force-pushed
the
fix_deprecation
branch
from
57af76c to
ece83bf
Compare
smarter
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13400 I introduced a deprecation to
compiletime.ops.int.ToString, mistakenly thinking that deprecation compares the version and I can set a future deprecation for 3.2.0.This PR removes the deprecation which will be reintroduced in 3.2.0 once we remove experimental from
compiletime.ops.any.ToStringthat comes in its stead.