Close Files.lines stream #14379
Merged
Close Files.lines stream #14379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested locally a few times without hitting the issue in #14376. |
smarter
reviewed
Jan 28, 2022
Comment on lines
50
to
54
| files.flatMap(path => toolArgsParse { | ||
| val stream = Files.lines(path, charset) | ||
| try stream.limit(10).toScala(List) | ||
| finally stream.close() | ||
| }) |
Member
There was a problem hiding this comment.
We normally use scala.util.Using for this:
Suggested change
| files.flatMap(path => toolArgsParse { | |
| val stream = Files.lines(path, charset) | |
| try stream.limit(10).toScala(List) | |
| finally stream.close() | |
| }) | |
| files.flatMap(path => toolArgsParse(Using(Files.lines(path, charset))(_.limit(10).toScala(List)))) |
dwijnand
approved these changes
Jan 28, 2022
Member
|
Oh, nvm, terminal doesn't mean close apparently. https://stackoverflow.com/a/27382060/463761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14376