Skip to content

Conversation

@mbovel
Copy link
Member

@mbovel mbovel commented Feb 11, 2022

[test_windows_full]

Joint work with @nicolasstucki

@mbovel
Copy link
Member Author

mbovel commented Feb 11, 2022

@nicolasstucki well that wasn't the problem. Same test failing:

image

Do you still want to merge this PR?

@mbovel mbovel requested a review from nicolasstucki February 11, 2022 16:00
@nicolasstucki
Copy link
Contributor

Using only ASCII characters seems better at this stage. I would merge this change.

@mbovel
Copy link
Member Author

mbovel commented Feb 11, 2022

Minor: looking at the output again, it's not evident that ----------- denotes a more important line than - - - - - -. Maybe we could use = and - à la Markdown? Feels more standard to me.

|------------------------------
|
| Dash and Dash-space
|
|- - - - - - - - - - - - - - -
|
|
|

|==============================
|
| Equal and Dash
|
|------------------------------
|
|
|

@mbovel mbovel merged commit 153b91a into scala:main Feb 14, 2022
@mbovel mbovel deleted the mb/mid-point branch February 14, 2022 14:58
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants