Test that TypeTrees are not in an unexpected tree #14752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
previously requested changes
Mar 22, 2022
Contributor
|
I wouldn't say that this fixes issue #1023, it is rather a first step towards having this infrastructure. |
nicolasstucki
suggested changes
Mar 24, 2022
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
We should add tests for many of the combinations we want to catch.
One way is to create those trees with macros and let the Ycheck catch them. The issue is that this would end up in a crash of the compiler. We could start improving Ychecking and emit some kind of fatal errors instead. These errors should include the stack trace and explicitly mention that this was an unexpected state in the tree. The unexpected state in the tree could be due to a compiler bug or a bug in a macro.
Now that we're not running this on every `typed` invocation, the compilation unit tree isn't going to be a top-level TypeTree.
I'm not sure what I had hit that lead me to this exclusion, but I'm not hitting now..
nicolasstucki
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1023