Handle this prefix in classes (in quote patterns) #14800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-14788
branch
from
9d5d5e4 to
250533c
Compare
smarter
reviewed
Apr 4, 2022
| case TermRef(qual: ThisType, _) if qual.classSymbol.is(Module, butNot = Package) => | ||
| tpd.ref(qual.classSymbol.companionModule) =?= qual2 | ||
| case _ => matched | ||
| case ref: Ident if qual2.symbol == defn.QuotedRuntimePatterns_patternHole => |
Member
There was a problem hiding this comment.
Why is patternHole special-cased now?
Contributor
Author
There was a problem hiding this comment.
If the pattern does not contain a hole, then we do not need to extract a value and can just call matched directly. The code was updated to cover holes in any part of the prefix.
smarter
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14788