Fix windows paths handling in legacy external link provider #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelou
suggested changes
Apr 25, 2022
Contributor
michelou
left a comment
michelou
left a comment
There was a problem hiding this comment.
On line 59 of file ExternalLocationProviderIntegrationTest.scala one should read split(File.pathSeparatorChar) instead of split(":") !
NB. Search for java.class.path in the test suites; for instance test file i14785.scala.
pikinier20
force-pushed
the
scaladoc/external-windows-paths
branch
from
3076e2f to
58a19ef
Compare
michelou
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14764