Fix #1503: anonymous application of FunctionX #1508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| new ApplyToUntyped(tree, fun1, funRef, proto, pt)(argCtx(tree)) | ||
| convertNewGenericArray(ConstFold(app.result)) | ||
| case mt: MethodType => |
Member
There was a problem hiding this comment.
I would squash this commit and the next one in the third commit, no need to record everything that was tried.
felixmulder
force-pushed
the
topic/fix-anon-apply
branch
from
678696b to
174edf4
Compare
Contributor
Author
odersky
requested changes
Sep 16, 2016
| // When this happens we simply remove the select to make expr1 a valid | ||
| // block expression. The `.apply` will be added back around the block when | ||
| // the block itself is adapted later. | ||
| val expr1 = typedExpr(tree.expr, pt)(exprCtx) match { |
Contributor
There was a problem hiding this comment.
But what if the .apply was added explicitly by the user? Then it should not be removed. It seems we need another solution.
Contributor
|
Superseded by #1522. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.