Add proper signatureHelp for unapply methods #15203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
commented
May 17, 2022
| patterns: List[tpd.Tree] | ||
| )(using Context): (Int, Int, List[SingleDenotation]) = | ||
| val patternPosition = patterns.indexWhere(_.span.contains(span)) | ||
| val activeParameter = extractParamTypess(fun.tpe.finalResultType.widen).headOption.map { params => |
Contributor
Author
There was a problem hiding this comment.
Possible performance optimization as this is computed twice. We need to find number of parameters we can unapply to but i can't pass it without changing the API
tgodzik
approved these changes
May 18, 2022
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Looks good! I just have one small comment
| List(productAccessors.map(_.info.finalResultType).toList) | ||
| else | ||
| ref.symbol.primaryConstructor.paramInfo.paramInfoss | ||
| case AppliedType(TypeRef(_, cls), (appliedType @ AppliedType(tycon, args)) :: Nil) |
Contributor
There was a problem hiding this comment.
Are you able to add examples to each case to say in which situation each is needed?
Contributor
Author
There was a problem hiding this comment.
I managed to simplify this logic and added comments why each case is necessary for proper handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignatureHelp is used in LSP to provide help when applying or unapplying.
The real value is displaying each parameter name, type and documentation to make it easier to understand and use given method.
Currently dotty signatureHelp allowed to easily show unapply signatures but with 2 problems:
It was caused by returning signature of unapply method, not its return type.
This implementation makes signatureHelp useful.
Example:
Previously:
After changes:
Provided tests checks all supported syntax for unapply available in Scala3. They were created according to https://docs.scala-lang.org/scala3/reference/changed-features/pattern-matching.html
Returned value contains parameter names only when result is a case class, only then we are certain that unapply patterns match its apply method ( there is also check if unapply is synthetic to check for possible overrides ).
SIgnature help for unapply doesn't show values for tuples as they act as clutter.
There are possible peformance optimizations to be made in places where i left comments in this PR, but I can't find better way to do it without changing existing API.
Fixes #15126