Prefer parameterless alternatives during ambiguous overload resolution #16315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheElectronWill
changed the title
TheElectronWill
force-pushed
the
fix-10715
branch
from
f532497 to
6226567
Compare
Contributor
|
Can we push this to staging please? I'd like to check it out to do a more convenient diff. |
Contributor
Author
|
Sure! I've copied the branch and pushed it to https://github.com/dotty-staging/dotty/tree/fix-10715 |
odersky
approved these changes
Nov 17, 2022
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
LGTM. Very clear refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10715.
Pair-programmed with @smarter this morning 😃
Parameterless alternatives were already preferred when there was no matching alternativ (#6955).
With this PR, they are also preferred when the alternatives are "ambiguous".