Fix reflect SuperType.supertpe and printing super types and type lambdas
#16968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweisenburger
force-pushed
the
quotes-printer-and-supertpe
branch
from
a28bd1d to
37ca1ee
Compare
| case _ => printFullClassName(within) | ||
| } | ||
| if (definition.symbol.flags.is(Flags.Protected)) { | ||
| def printWithin(within: Option[TypeRepr]) = within match |
Contributor
There was a problem hiding this comment.
We should have a test for this change.
Contributor
Author
There was a problem hiding this comment.
I added a test case for printing the modifiers to the second commit.
pweisenburger
force-pushed
the
quotes-printer-and-supertpe
branch
from
37ca1ee to
8aba6f4
Compare
nicolasstucki
approved these changes
Jun 16, 2023
nicolasstucki
added a commit
that referenced
this pull request
Jun 22, 2023
This test had a conflict with #16968.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reflect
SuperType.supertpeto returnsupertpeinstead ofthistpe.Fixes the printer for supertypes. Maybe this could be improved as it currently ignores the
supertpefield when printing. But it's aligned with PlainPrinter.Fixes the printer to print type lambdas as
=>>instead of=>.Fixes printing private and protected modifiers (before,
privatewas only printed when scoped to an enclosing type definition).