Skip to content

Add test for issue #17231 #17300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sporarum merged 1 commit into from
Apr 18, 2023
Merged

Add test for issue #17231 #17300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/test-resources/repl/i17231
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
scala> summon[ValueOf["a"]]
val res0: ValueOf["a"] = scala.ValueOf@61
Copy link
Contributor

@nicolasstucki nicolasstucki Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This toString uses the hash. This test will not be stable.

Copy link
Contributor Author

@Sporarum Sporarum Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I looked at the neighboring i15493 which also had hashes, so I assumed it would be fine

Copy link
Contributor Author

@Sporarum Sporarum Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you advise I proceed ?

Copy link
Member

@dwijnand dwijnand Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash of ValueOf is of its underlying type, String, which is of the content. "a" is hex 0x61, which isn't going to change. So this is fine.