Do not remove inline method implementations until PruneErasedDefs #17408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Same as #17400 but for splices (macros). |
nicolasstucki
force-pushed
the
do-not-remove-inline-method-implementations-until-PruneErasedDefs
branch
3 times, most recently
from
2df765b to
5c9c61c
Compare
nicolasstucki
commented
May 4, 2023
| // Shrink size of the tree. The methods have already been inlined. | ||
| // TODO move to FirstTransform to trigger even without quotes | ||
| cpy.DefDef(tree)(rhs = defaultValue(tree.rhs.tpe)) | ||
| tree |
Contributor
Author
There was a problem hiding this comment.
We only removed the bodies of inline methods in a file containing a quote. All other inline methods kept the contents of inlined definitions until PruneErasedDefs.
nicolasstucki
force-pushed
the
do-not-remove-inline-method-implementations-until-PruneErasedDefs
branch
from
5c9c61c to
82236ae
Compare
smarter
approved these changes
May 4, 2023
smarter
deleted the
do-not-remove-inline-method-implementations-until-PruneErasedDefs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the tree in the inline method will pass through all checks after first transform.