Avoid shadowing by private definitions in more situations #18142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a tricky case where when selecting a member we find a private definition first, which is not accessible, but which shadows another definition. We handled that case correctly on direct member selection, but not when a member was looked up in an import, not when a member was searched in an implicit.
dwijnand
approved these changes
Jul 4, 2023
Member
dwijnand
left a comment
dwijnand
left a comment
There was a problem hiding this comment.
Thank you! I'd just reached "def implicitMembers" when you'd submitted 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a tricky case where when selecting a member we find a private definition first, which is not accessible, but which shadows another definition. We handled that case correctly on direct member selection, but not when a member was looked up in an import, nor when a member was searched in an implicit.
Fixes #18135