Skip to content

Backport "Fix: Error Sidebar PR failed test" to LTS #18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kordyjan merged 1 commit into from
Nov 21, 2023
Merged

Backport "Fix: Error Sidebar PR failed test" to LTS #18987

Kordyjan merged 1 commit into from
Nov 21, 2023

Conversation

@Kordyjan
Copy link
Contributor

@Kordyjan Kordyjan commented Nov 17, 2023

Backports #17959 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@Dedelweiss @Kordyjan
Fix: Error Sidebar PR failed test (#17959)
c11b859 
The purpose of this Pull request is to correct my PR
#17229
Sorry for this failure.
I have tested the following command locally and my tests pass.
`sbt ";dist/pack ;scala3-bootstrapped/compile
;scala3-bootstrapped/test"`

[test_windows_full]

Fixes: #17963
[Cherry-picked d83aa49]
Base automatically changed from lts-17960 to release-3.3.2 November 21, 2023 11:14
@Kordyjan
Copy link
Contributor Author

Kordyjan commented Nov 21, 2023

No new regressions found in https://virtuslab.github.io/community-build3/2023/11/17/3.3.2-rc1-bin-57c5334015ee4aa800b24b4f8691a076f20d9069.html. Merging, up to PR 17991.

@Kordyjan Kordyjan merged commit a227579 into release-3.3.2 Nov 21, 2023
@Kordyjan Kordyjan deleted the lts-17959 branch November 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kordyjan @Dedelweiss