Skip to content

improvement: Support completions for implicit classes #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tgodzik merged 1 commit into from
Dec 21, 2023
Merged

improvement: Support completions for implicit classes #19314

tgodzik merged 1 commit into from
Dec 21, 2023

Conversation

@tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Dec 20, 2023

Previously, we would only support extension methods and not the old style implicit classes. Now, those are supported also.

Introduced in scalameta/metals#5904

@tgodzik
improvement: Support completions for implicit classes
3c5e216 
Previously, we would only support extension methods and not the old style implicit classes. Now, those are supported also.

Introduced in scalameta/metals#5904
@tgodzik tgodzik requested a review from rochala December 20, 2023 17:02
@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Dec 20, 2023
@tgodzik tgodzik merged commit a28d1a6 into scala:main Dec 21, 2023
@tgodzik tgodzik deleted the implicit-classes branch December 21, 2023 14:39
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@tgodzik tgodzik removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 8, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jun 25, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
@WojciechMazur
Backport "improvement: Support completions for implicit classes" to L…
74b2da5 
…TS (#20808)

Backports #19314 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochala rochala rochala approved these changes

Assignees

No one assigned

Labels

area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@tgodzik @rochala @Kordyjan