Use 3.4.0-RC2 for MiMa checks #19503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Jan 22, 2024
| val LibraryForward: Map[String, Seq[ProblemFilter]] = Map( | ||
| // Additions that require a new minor version of the library | ||
| Build.previousDottyVersion -> Seq( | ||
| // This language feature is not in 3.4.0-RC1 but will be added in 3.4.0-RC2 |
Contributor
Author
There was a problem hiding this comment.
There is something broken in 3.4.0-RC2. The changes of #19316 where modified when backporting
https://github.com/lampepfl/dotty/pull/19316/files#diff-54406bedea7a8bfcd15a49467ca97594ae3c8ef3de104b0ebe5828d146b8ecd4R36
to
5fe047b#diff-54406bedea7a8bfcd15a49467ca97594ae3c8ef3de104b0ebe5828d146b8ecd4R36
This implies that we did not add the expected 3.5 language tag.
Contributor
Author
There was a problem hiding this comment.
We have two ways to fix this
- We fix this and release a
3.4.0-RC3 - We do not fix it and revert temporarily (for 3.4.0) the
3.5version from the main branch. Then we add it back when we decide to go to3.5.
15 tasks
Contributor
Author
|
Replaced with #19529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.