Skip to content

Make -Xprompt work as desired under -Werror #19765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwijnand merged 1 commit into from
Feb 26, 2024
Merged

Make -Xprompt work as desired under -Werror #19765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions compiler/src/dotty/tools/dotc/reporting/ConsoleReporter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package reporting

import core.Contexts.*
import java.io.{ BufferedReader, PrintWriter }
import Diagnostic.Error
import Diagnostic.*

/**
* This class implements a Reporter that displays messages on a text console
Expand All @@ -18,9 +18,11 @@ class ConsoleReporter(

override def doReport(dia: Diagnostic)(using Context): Unit = {
super.doReport(dia)
dia match
case dia: Error if ctx.settings.Xprompt.value => Reporter.displayPrompt(reader, writer)
case _ =>
if ctx.settings.Xprompt.value then
dia match
case _: Error => Reporter.displayPrompt(reader, writer)
case _: Warning if ctx.settings.XfatalWarnings.value => Reporter.displayPrompt(reader, writer)
case _ =>
}
}

Expand Down