Adds special treatment for Predef.classOf in object initialization checker
#20945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
pushed a commit
that referenced
this pull request
Sep 1, 2024
This is an updated PR of #20945, making the global initialization checker skips the analysis of `Predef.classOf` in scala2-library, since it is a stub method in tasty and is replaced by actual class representations in the backend. This prevents related warnings when running test_scala2_library_tasty. --------- Co-authored-by: EnzeXing <enzexing12@gmail.com>
Contributor
|
Closing in favour of #21523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Predef.classOfis a stub method that is replaced by runtime class representation after compilation, so when the object initialization checker analyzes tasty file, any call toPredef.classOfshould be treated specially, so warnings related toPredef.classOfcan be avoided.