Skip to content

Avoid import suggestion thread hang if -Ximport-suggestion-timeout <= 1 #21434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwijnand merged 1 commit into from
Aug 28, 2024
Merged

Avoid import suggestion thread hang if -Ximport-suggestion-timeout <= 1 #21434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/ImportSuggestions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,9 @@ trait ImportSuggestions:
* `name` that are applicable to `T`.
*/
private def importSuggestions(pt: Type)(using Context): (List[TermRef], List[TermRef]) =
val timer = new Timer()
val allotted = ctx.run.nn.importSuggestionBudget
if allotted <= 1 then return (Nil, Nil)
val timer = new Timer()
implicits.println(i"looking for import suggestions, timeout = ${allotted}ms")
val start = System.currentTimeMillis()
val deadLine = start + allotted
Expand Down