Backport "Avoid import suggestion thread hang if -Ximport-suggestion-timeout <= 1" to LTS #22112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
backport-lts-3.3-20144
branch
from
a89e7d4 to
b51eceb
Compare
Without this change, if -Ximport-suggestion-timeout is set to 0 or 1, we would create a Timer thread and never cancel it, making the whole execution thread hang. [Cherry-picked 345bfc6]
WojciechMazur
force-pushed
the
backport-lts-3.3-21434
branch
from
e382789 to
ef91aa7
Compare
Contributor
Author
|
No regressions detected in the community build up to backport-lts-3.3-21857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #21434 to the 3.3.5.
PR submitted by the release tooling.
[skip ci]