Skip to content

Under betterFors don't drop the trailing map if it would result in a different type (also drop _ => ()) #22619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KacperFKorban merged 6 commits into from
Feb 21, 2025
Merged

Under betterFors don't drop the trailing map if it would result in a different type (also drop _ => ()) #22619

KacperFKorban merged 6 commits into from
Feb 21, 2025

Conversation

@KacperFKorban
Copy link
Member

@KacperFKorban KacperFKorban commented Feb 17, 2025

closes #21804

sjrd
sjrd reviewed Feb 18, 2025
View reviewed changes
@KacperFKorban KacperFKorban marked this pull request as ready for review February 19, 2025 12:34
odersky
odersky approved these changes Feb 20, 2025
View reviewed changes
@odersky odersky assigned KacperFKorban and unassigned odersky Feb 20, 2025
odersky
odersky reviewed Feb 20, 2025
View reviewed changes
@KacperFKorban KacperFKorban enabled auto-merge (squash) February 21, 2025 09:55
@KacperFKorban KacperFKorban merged commit d4421d0 into scala:main Feb 21, 2025
28 checks passed
@KacperFKorban KacperFKorban deleted the better-fors-fix branch February 21, 2025 11:44
@odersky odersky mentioned this pull request Feb 21, 2025
Merged
@Gedochao Gedochao added stat:needs decision Some aspects of this issue need a decision from the maintainance team. stat:needs preview Features which may first be released under --preview labels Feb 24, 2025
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
@WojciechMazur WojciechMazur mentioned this pull request Jun 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd left review comments

@odersky odersky odersky approved these changes

Assignees

@KacperFKorban KacperFKorban

Labels

stat:needs decision Some aspects of this issue need a decision from the maintainance team. stat:needs preview Features which may first be released under --preview

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

betterFors trailing map elimination can change the resulting type

5 participants

@KacperFKorban @sjrd @odersky @Gedochao @WojciechMazur