Skip to content

Fix span of private this warning #23947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
som-snytt merged 2 commits into from
Sep 18, 2025
Merged

Fix span of private this warning #23947

som-snytt merged 2 commits into from
Sep 18, 2025

Conversation

@som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Sep 17, 2025

Fixes #23940

@som-snytt
Copy link
Contributor Author

som-snytt commented Sep 17, 2025

Apparently I'm the only one who can't run tests after recent repo changes.

Compilation failed for: tests/warn/private-this-3.4.scala
-> following the diagnostics:
 at 1: value 3.4 is not a member of object language
 at 3: package scala.compiletime does not have a member method summonFrom
 at 4: Ignoring [this] qualifier.

He-Pin
He-Pin reviewed Sep 17, 2025
View reviewed changes
tests/warn/private-this-3.4.check Outdated
-- Warning: tests/warn/private-this-3.4.scala:5:18 ---------------------------------------------------------------------
| ^^^^^^
| Ignoring [this] qualifier.
| This syntax will be deprecated in the future; it should be dropped.
Copy link
Contributor

@He-Pin He-Pin Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[this] syntax ... ?

Copy link
Contributor Author

@som-snytt som-snytt Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a joke, but maybe you are right.

One must be totally committed to one's craft.

Copy link
Contributor Author

@som-snytt som-snytt Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more sober words which I hope are helpful.

We take for granted what "this" and "it" mean in an ordinary sentence, but the reader must perform the substitutions. We can make our meaning more plain by avoiding variables (pronouns) when we can.

@som-snytt som-snytt force-pushed the issue/23940-this-span branch from 2da56bc to 7945798 Compare September 17, 2025 20:44
@som-snytt som-snytt marked this pull request as ready for review September 17, 2025 21:37
@Gedochao Gedochao requested a review from noti0na1 September 18, 2025 07:32
noti0na1
noti0na1 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@som-snytt som-snytt merged commit 55faeeb into scala:main Sep 18, 2025
102 of 104 checks passed
@som-snytt som-snytt deleted the issue/23940-this-span branch September 18, 2025 11:24
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

@Gedochao Gedochao Gedochao approved these changes

+1 more reviewer

@He-Pin He-Pin He-Pin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@noti0na1 noti0na1

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

wrong position for [this]

5 participants

@som-snytt @He-Pin @noti0na1 @Gedochao @WojciechMazur